Re: [PATCH v3 08/16] btrfs: dedup: Implement btrfs_dedup_calc_hash interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wang,

[auto build test WARNING on tip/perf/core]
[also build test WARNING on v4.4-rc8]
[cannot apply to btrfs/next next-20160106]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Qu-Wenruo/btrfs-dedup-Introduce-dedup-framework-and-its-header/20160107-091211
config: s390-allmodconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=s390 

All warnings (new ones prefixed by >>):

   fs/btrfs/dedup.c: In function 'btrfs_dedup_calc_hash':
>> fs/btrfs/dedup.c:558:1: warning: 'btrfs_dedup_calc_hash' uses dynamic stack allocation
    }
    ^

vim +/btrfs_dedup_calc_hash +558 fs/btrfs/dedup.c

   542			return -ENOMEM;
   543		for (i = 0; sectorsize * i < dedup_bs; i++) {
   544			char *d;
   545	
   546			/* TODO: Add support for subpage size case */
   547			p = find_get_page(inode->i_mapping,
   548					  (start >> PAGE_CACHE_SHIFT) + i);
   549			WARN_ON(!p);
   550			d = kmap_atomic(p);
   551			memcpy((data + sectorsize * i), d, sectorsize);
   552			kunmap_atomic(d);
   553			page_cache_release(p);
   554		}
   555		ret = hash_data(dedup_info, data, dedup_bs, hash);
   556		kfree(data);
   557		return ret;
 > 558	}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux