David Sterba wrote on 2015/12/03 18:47 +0100:
On Tue, Dec 01, 2015 at 08:50:57AM +0800, Qu Wenruo wrote:
Btrfsck already gives quite good clue on the problem:
ERROR: chunk_root block unaligned: 4294967168
ERROR: chunk_root block unaligned: 4294967168
Chunk root in superblock is not aligned, and the superblock is not valid.
It would be better to copy all these btrfs-progs enhancement to kernel.
We do have the alignment check in kernel, but it's in the early phase
where we don't know if nodesize is reliable and print only a warning.
This can be enhanced by the following method:
1) Check sectorsize first
Only several sector size is valid for current btrfs:
4K, 8K, 16K, 32K, 64K
Just five numbers, quite easy to check.
Or if anyone is going to extend supported sectorsize, we can change
the check to if the number is power of 2 starting from 4K.
2) Check nodesize/leafsize then
It should be aligned to sectorsize.
And nodesize must match with leafsize.
Currently, it's done out of check_super_valid(), we can integrate it.
3) Check all super root bytenr against *sectorsize*
Yeah, not nodesize.
As some old bad convert will cause metadata extent unaligned to
nodesize(just before my convert rework patch), but only aligned to
sectorsize.
So only check alignment of sectorsize.
If you are OK with this idea, I can make the patch soon.
Thanks,
Qu
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
