Re: [PATCH v2] btrfs-progs: fsck: Fix a false alert where extent record has wrong metadata flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Christoph Anton Mitterer wrote on 2015/11/26 16:20 +0100:
Hey.

I can confirm that the new patch fixes the issue on both test
filesystems.

Thanks for working that out. I guess there's no longer a need to keep
that old filesystems now?!

Of course no need to keep.
But since there is no real error, feel free to keep using it or just re format it with skinny-metadata.

Thanks,
Qu


Cheers,
Chris.

On Thu, 2015-11-26 at 15:27 +0100, David Sterba wrote:
On Wed, Nov 25, 2015 at 02:19:06PM +0800, Qu Wenruo wrote:
In process_extent_item(), it gives 'metadata' initial value 0, but
for
non-skinny-metadata case, metadata extent can't be judged just from
key
type and it forgot that case.

This causes a lot of false alert in non-skinny-metadata filesystem.

Fix it by set correct metadata value before calling
add_extent_rec().

Reported-by: Christoph Anton Mitterer <calestyo@xxxxxxxxxxxx>
Signed-off-by: Qu Wenruo <quwenruo@xxxxxxxxxxxxxx>

Patch replaced, thanks. The test image is pushed as well.


--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux