Hi, David Sterba > -----Original Message----- > From: David Sterba [mailto:dsterba@xxxxxxx] > Sent: Tuesday, October 27, 2015 10:20 PM > To: Zhao Lei <zhaolei@xxxxxxxxxxxxxx> > Cc: linux-btrfs@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] btrfs-progs: mkfs: Enable -d dup for single device > > On Tue, Oct 13, 2015 at 06:29:41PM +0800, Zhao Lei wrote: > > Current code don't support dup profile in single device, except it is > > in mixed mode, because following reason: > > 1: In some ssd with deduplication function, it have no effect. > > 2: For a physical device, it the entire disk broken, -d dup can > > not help. > > 3: Half performance comparing with single profile. > > 4: We have a workaround: Create multi-partition in single device, > > and btefs will treat them as multi device. > > > > Instead of refuse -d dup, we have a better choise: > > Give user a chance to select, and output a warning to notice above > > problem. > > > > Signed-off-by: Zhao Lei <zhaolei@xxxxxxxxxxxxxx> > > FYI, I've queued the patch for 4.4 (or later) whenever we're ready on the kernel > side. Thanks. I'm doing relative tests(xfstests, userland tools, functions as scrub, balance, ...) on it. Thanks Zhaolei -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
