Hi, David Sterba Thanks for review. > -----Original Message----- > From: David Sterba [mailto:dsterba@xxxxxxx] > Sent: Friday, September 25, 2015 6:50 PM > To: Zhao Lei <zhaolei@xxxxxxxxxxxxxx> > Cc: linux-btrfs@xxxxxxxxxxxxxxx; Qu Wenruo <quwenruo@xxxxxxxxxxxxxx> > Subject: Re: [PATCH v2 1/2] btrfs-progs: Introduce warning and error for > common use > > On Wed, Sep 16, 2015 at 05:40:46PM +0800, Zhao Lei wrote: > > +static inline void __veprintf(const char *prefix, const char *format, > > + va_list ap) > > +{ > > + if (prefix) > > + fprintf(stderr, "%s", prefix); > > + vfprintf(stderr, format, ap); > > I'm not sure we need this helper. All it does it prints a fixed string, we can > simply add fputs("prefix", stderr) into warning/error functions. > This wrapper is to support locale in future: Make all message output by one function, then we can put locale code into it simply. But now it is hard to introduce locale, because user-land tools changes output frequently, we need to wait the output about fixed. So I removed __veprintf() in v3, we can modify it when we need. > > +static inline int warning_on(int condition, const char *fmt, ...) { > > + if (!condition) > > + return 0; > > + > > + va_list args; > > Please do not put declaration(s) after statements. > Fixed in v3. > > +static inline int error_on(int condition, const char *fmt, ...) { > > + if (!condition) > > + return 0; > > + > > + va_list args; > > dtto > Fixed in v3. Thanks Zhaolei > > + > > + va_start(args, fmt); > > + __veprintf("ERROR: ", fmt, args); > > + va_end(args); > > + > > + return 1; > > +} -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
