On Tue, Sep 22, 2015 at 05:29:38PM +0100, Luis de Bethencourt wrote: > check-integrity is using -1 instead of the -ENOMEM defined macro to > specify that a buffer allocation failed. Since the error number is > propagated, the caller will get a -EPERM which is the wrong error > condition. Agreed. btrfsic_process_superblock can be called from the mount path so getting EPERM would be confusing. > Also, the smatch tool complains with the following warnings: > btrfsic_process_superblock() warn: returning -1 instead of -ENOMEM is sloppy > btrfsic_read_block() warn: returning -1 instead of -ENOMEM is sloppy > > Signed-off-by: Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx> Reviewed-by: David Sterba <dsterba@xxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
