Re: [PATCH v2 2/4] btrfs-progs: Use common unit parser for btrfs filesystem command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 31, 2015 at 07:03:42PM +0800, Zhao Lei wrote:
> @@ -859,88 +859,23 @@ out:
>  const char * const cmd_filesystem_usage_usage[] = {
>  	"btrfs filesystem usage [options] <path> [<path>..]",
>  	"Show detailed information about internal filesystem usage .",
> -	"-b|--raw           raw numbers in bytes",
> -	"-h|--human-readable",
> -	"                   human friendly numbers, base 1024 (default)",
> -	"-H                 human friendly numbers, base 1000",
> -	"--iec              use 1024 as a base (KiB, MiB, GiB, TiB)",
> -	"--si               use 1000 as a base (kB, MB, GB, TB)",
> -	"-k|--kbytes        show sizes in KiB, or kB with --si",
> -	"-m|--mbytes        show sizes in MiB, or MB with --si",
> -	"-g|--gbytes        show sizes in GiB, or GB with --si",
> -	"-t|--tbytes        show sizes in TiB, or TB with --si",
> -	"-T                 show data in tabular format",

You're removing too much, -T must stay. Due to that, the whole getopt
loop must stay as well. Please update this patch, the rest from the
series is applied.

> +	HELPINFO_OUTPUT_UNIT,
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux