Hi, David Sterba > -----Original Message----- > From: David Sterba [mailto:dsterba@xxxxxxxx] > Sent: Thursday, August 06, 2015 1:03 AM > To: Zhao Lei > Cc: linux-btrfs@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/3] btrfs: Error handle for get_ref_objectid_v0() in > relocate_block_group() > > On Wed, Aug 05, 2015 at 06:00:02PM +0800, Zhao Lei wrote: > > We need error checking code for get_ref_objectid_v0() in > > relocate_block_group(), to avoid unpredictable result, especially for > > accessing uninitialized value(when function failed) after this line. > > > > Signed-off-by: Zhao Lei <zhaolei@xxxxxxxxxxxxxx> > > Reviewed-by: David Sterba <dsterba@xxxxxxxx> > Thanks for review! > Are there even filesystems with v0 refs? Rarely, I think. (Just a accidental found in debuging another problem) But for current code, we need hold correct code until we remove v0 refs support. Thanks Zhaolei -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
