Re: [PATCH v2] btrfs: Show detail information when mount failed on missing devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




 Reviewed-by: Anand Jain <anand.jain@xxxxxxxxxx>

On 07/20/2015 05:55 PM, Zhaolei wrote:
From: Zhao Lei <zhaolei@xxxxxxxxxxxxxx>

When mount failed because missing device, we can see following
dmesg:
  [ 1060.267743] BTRFS: too many missing devices, writeable mount is not allowed
  [ 1060.273158] BTRFS: open_ctree failed

This patch add missing_device_number and tolerated_missing_device_number
to above output, to let user know what really happened, and helps
bug-report and debug.

dmesg after patch:
  [  127.050367] BTRFS: missing devices(1) exceeds the limit(0), writeable mount is not allowed
  [  127.056099] BTRFS: open_ctree failed

Changelog v1->v2:
1: Changed to more clear description, suggested-by:
    Anand Jain <anand.jain@xxxxxxxxxx>

Suggested-by: Anand Jain <anand.jain@xxxxxxxxxx>
Signed-off-by: Zhao Lei <zhaolei@xxxxxxxxxxxxxx>
---
  fs/btrfs/disk-io.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 2eda03b..5b44e02 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -2950,8 +2950,9 @@ retry_root_backup:
  	if (fs_info->fs_devices->missing_devices >
  	     fs_info->num_tolerated_disk_barrier_failures &&
  	    !(sb->s_flags & MS_RDONLY)) {
-		printk(KERN_WARNING "BTRFS: "
-			"too many missing devices, writeable mount is not allowed\n");
+		pr_warn("BTRFS: missing devices(%llu) exceeds the limit(%d), writeable mount is not allowed\n",
+			fs_info->fs_devices->missing_devices,
+			fs_info->num_tolerated_disk_barrier_failures);
  		goto fail_sysfs;
  	}


--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux