Re: [PATCH] btrfs: its btrfs_err() instead of btrfs_error()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 17, 2015 at 11:45:23PM +0800, Anand Jain wrote:
> sorry I indented to use btrfs_err() and I have no idea
> how btrfs_error() got there.
> infact I was thinking about these kind of oversights
> since these two func are too closely named.

Indeed, it's confusing. I suggest to convert btrfs_errror to
btrfs_std_error and change the prototype to

#define btrfs_std_error(fs_info, errno, fmt, args...)

and switch all btrfs_error users to pass NULL for 'fmt'.

> Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx>

Reviewed-by: David Sterba <dsterba@xxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux