On Wed, Jun 03, 2015 at 06:16:23PM +0530, Chandan Rajendra wrote: > Consider a file having 10 4k blocks (i.e. blocks in the range [0 - 9]). If the > defrag ioctl was invoked for the block range [3 - 6], then max_to_defrag > should actually have the value 4. Instead in the current code we end up > setting it to 6. > > Now, this does not (yet) cause an issue since the first part of the while loop > condition in btrfs_defrag_file() (i.e. "i <= last_index") causes the control > to flow out of the while loop before any buggy behavior is actually caused. So > the patch just makes sure that max_to_defrag ends up having the right value > rather than fixing a bug. I did run the xfstests suite to make sure that no > new regressions were introduced by this patch. Thank, put that kind of detailed description into the changelog. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
