On Fri, May 08, 2015 at 04:57:14PM +0800, Qu Wenruo wrote: > > Respecting the current syntax, the way to set the uuid is: > > > > btrfs prop set -t filesytem /dev/sdx uuid ...UUID... > > > > In this special case, the property handler should check if the device is > > unmounted (and is a btrfs filesystem) and then do the rest. > This is one good idea, but I'm afraid it may still be confusing. > And things may get even worse when we try to move everything into > btrfs-prop, > E.g. if we auto move seeding flag to prop, we must give a quite detailed > explain on which property is offline. > > So I prefer to add a new type called offline, and put uuid change with > other btrfstune function into this type. > IMHO this should provide a good explain on which is online and which is > offline. > > How do you think about this method? I don't think that 'offline' is a good choice. The type should denote the modified object, ie device, inode, filesystem. What's 'offline' in this context? The property interface can be used to modify other features both for mounted and unmounted filesystem, I agree that this should be done in a way that's not confusing. There are operations that are allowed on an unmounted fs (seeding), mounted + unmounted (extref feature) etc. so I think we could add options like --check-unmounted that would not allow to act on a mounted filesystem. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
