Thanks for reply. On Wed, May 6, 2015 at 5:22 PM, Anand Jain <Anand.Jain@xxxxxxxxxx> wrote: > > > fix typo. (I have to blame thunderbird's bug which vanishes > some of the words as I scroll up and down in the 'write' window.). > > On 05/06/2015 05:15 PM, Anand Jain wrote: >> >> >> >> On 05/05/2015 11:38 PM, David Sterba wrote: >>> >>> On Thu, Apr 30, 2015 at 05:07:24PM +0800, xuw2015@xxxxxxxxx wrote: >>>> >>>> From: George Wang <xuw2015@xxxxxxxxx> >>>> >>>> First try to find the device matches specified device path, if >>>> nothing, then >>>> find the device by (devid, dev_uuid). This can fix the regression for >>>> replacing an offline device which path is held in btrfs_device. >>> >>> >>> I vaguely remember similar patches sent by Anand, CCed. >> >> >> George, >> >> Critically we don't need this patch. right ? Yes, I agree it. >> Anyway user of replace cli can use devid if device read fails. >> >> I think David is talking about: >> [PATCH] device delete by devid We can delete the device by devid on behalf of "btrfs_find_device". In my opinion, the dev path is easier and humanized to use. This was OK before, but now I can not replace offline device by path. So I consider it as a regression. Anyway, maybe we should support replace offline device by path in the future. Thanks, George >> >> it was critical for device delete. since there wasn't device >> delete by devid. I used device delete by devid instead of >> device path strcmp mainly because to maintain consistency >> between device replace and delete. >> the above patch set also provides code cleanups between >> device replace and delete codes. >> >> Thanks, Anand -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
