Am 31.03.2015 14:31 schrieb Tom Van Braeckel:
Err, upon further inspection, I think that this was a false positive. Btrfs relies on the initial value of the private_data member of a file being NULL in the regular ioctl operation handler for BTRFS_IOC_TRANS_START but it does not use the miscdevice framework for those files. It *does* use the miscdevice framework in the ioctl operation handler of the /dev/btrfs-control file but there it does not use the file's private_data member. So IMHO, the proposed patch is not necessary...
This is offtopic, assuming you are right and didn't find more affected places:
Then I would say you could re-post the real change (to misc_open() ) to the relevant people for 4.2 (not 4.1), so either wait for 4.0 to be released or try something like "for 4.2" in the topic (or as a comment after the --- dashes in
the patch email) I would want to have it in -next for one cycle at least. Further, I would remove the code-comment you had here https://lkml.org/lkml/2015/1/9/718 because GregKH already pulled this in (a little too early ;) : https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=03190c67ff72b5c56b24266762ab8abe68970f45 which is extractable kernel documenation. You could somehow link to it in the commit message. martin -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
