On Tue, Mar 03, 2015 at 09:00:36AM -0500, Josef Bacik wrote: > On 03/03/2015 06:18 AM, Dongsheng Yang wrote: >> On 02/26/2015 02:05 PM, Dongsheng Yang wrote: >>> Wait a minute, this patch seems not working well in accounting quota >>> number when >>> deleting data shared by different subvolumes. >>> >>> I will investigate more about it and send a V2 out. >> I have sent a fstest >> [PATCH] fstest: btrfs: add a test for quota number when deleting a >> subvol. >> for this problem I was trying to solve in this patch. >> >> Please consider reverting the two commits introduced the problem: >> >> e339a6b0 (Btrfs: __btrfs_mod_ref should always use no_quota) >> 1152651a (btrfs: qgroup: account shared subtrees during snapshot delete) >> > > We aren't reverting these two commits, what we had was worse before than it > is now. We need to figure out why this is resulting in problems and fix > that rather than throwing out a whole bunch of work. Thanks, Agreed, reverting these would re-introduce far more problems than it would solve. --Mark -- Mark Fasheh -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
