Re: [PATCH] btrfs-progs: Fix a infinite loop when fixing nlink if file name conflicts twice.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 23, 2015 at 04:00:04PM +0800, Qu Wenruo wrote:
> There is a case that can cause nlink fix function.
> 
> For example, lost+found dir already has the following files:
> ---------------------------
> |ino	|filename	  |
> |-------------------------|
> |258	|normal_file	  |
> |259	|normal_file.260  |
> ---------------------------
> The next inode to be fixed is the following:
> ---------------------------
> |260	|normail_file	  |
> ---------------------------
> 
> And when trying to move inode to lost+found dir, its file name conflicts
> with inode 258, and even add ".INO" suffix, it still conflicts with
> inode 259.
> 
> Since the move failed, the LINK_COUNT_ERR flag is not cleared, the inode
> record will not be freed, btrfsck will try fix it again and again,
> causing the infinite loop.
> 
> The patch will first change the ".INO" suffix naming to a loop behavior,
> and clear the LINK_COUNT_ERR flag anyway to avoid infinite loop.
> 
> Reported-by: Naohiro Aota <naota@xxxxxxxxx>
> Signed-off-by: Qu Wenruo <quwenruo@xxxxxxxxxxxxxx>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux