Re: [PATCH] Btrfs: fix allocation size calculations in alloc_btrfs_bio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 20, 2015 at 9:35 AM, David Sterba <dsterba@xxxxxxx> wrote:
On Thu, Feb 19, 2015 at 08:59:30PM -0500, Chris Mason wrote:
 Since commit 8e5cfb55d3f (Btrfs: Make raid_map array be inlined in
 btrfs_bio structure), the raid map array is allocated along with the
btrfs bio in alloc_btrfs_bio. The calculation used to decide how much
 we need to allocate was using the wrong parameter passed into the
 allocation function.

The passed in real_stripes will be zero if a target replace operation
 is not currently running.  We want to use total_stripes instead.

 Signed-off-by: Chris Mason <clm@xxxxxx>
 Reported-by: Dave Sterba <dsterba@xxxxxxx>

Tested-by: David Sterba <dsterba@xxxxxxx>

Current master + this patch with full slub_debug is now ok with
btrfs/023.

Thanks Dave. It also survived all night with raid6 and stress.sh. I'm sending to Linus today.

-chris



--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux