Re: [PATCH 1/4] Btrfs-progs: add regression tests for sysfs contents during btrfs device management

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 02/12/2015 02:19 AM, David Sterba wrote:
On Mon, Feb 09, 2015 at 04:24:12PM +0800, Qu Wenruo wrote:
This tests are not even not bind to btrfs-progs.
They are kernel tests in fact.

So btrfs-progs isn't the best place for it.

Well, I agree. Userspace tools mostly exercise the checker, repair or
image, ie. mostly offline actions.  The mount test that now exists is to
really check that the fixed filesystem can be mounted.

The tests Anand proposes perform add, replace, seeding etc. That really
belongs to fstests.

 we could get sysfs data collection in fstests like this..

 _btrfs_progs()
 {
     btrfs $*
     [[ -z TEST_SYSFS ]] && collect_sysfs_data
 }
 and TEST_SYSFS must be set in the config file.

 Similarly for mount, unmount, modload and modunload etc..

For now my patches are already tested with test-btrfs-devmgt, which is uploaded here git@xxxxxxxxxx:asj/test-btrfs-devmgt.git for reference, (but I don't intend to maintain it though).

Thanks,  Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux