-------- Original Message --------
Subject: Re: [PATCH v3 00/10] Enhance btrfs-find-root and open_ctree()
to provide better chance on damaged btrfs.
From: David Sterba <dsterba@xxxxxxx>
To: Qu Wenruo <quwenruo@xxxxxxxxxxxxxx>
Date: 2015年02月12日 01:52
On Wed, Feb 11, 2015 at 08:33:03AM +0800, Qu Wenruo wrote:
Also, since only 2 patches is modified(although other part is slightly
modified to match the change), to avoid mail bombing, I created the pull
request on github and only send the first 2 patches with cover-letter.
https://github.com/kdave/btrfs-progs/pull/5
Sending the changed patches only is ok (if you point me at the rest of
the patches), but it's not necessary to open the github pull request.
The version to version changelogs are also stored in the commit
changelogs, that's a bit unexpected for a branch to be pulled.
Oh, very sorry for this.
I was meant to save your time, but I forgot that pull branch won't emit
the changelog like patches.
Pulled except the last patch, and I've cleaned up some bits so please
have a look. It's basically what I'd tell you during a normal review but
now it was easier to do myself.
Thanks for merging and modifying them.
It seems that my naming sense is not so good and the new naming looks
good for me, except some of them,
like OPEN_CTREE_SUPPRESS_CHECK_TREE_ERROR seems too long for me, but
that's all right and doesn't
do any harm.
And it seems that the patch I send it still out of date and some naming
changes in my v3 patch doesn't show in
it...
Sorry for taking your time to change them.
My concern about the patch "btrfs-progs: Allow open_ctree use backup
tree root or search it automatically if primary..." is the
'automatically' part. Falling to the backup roots should be IMO on
request. The tools should have (and some of them already do have)
commandline options to request a given backup root. That way the user
can try the default action and then decide if the backup roots are fine
for use.
What about ask user to do such fallback method?
IMHO, such way should take a balance for average user and advanced user
who can, for example, extract
the bad block and fix it manually without corruption.
Current btrfsck has a problem that doesn't give enough info on possible
solutions.
The case is much like --init-(csum/extent)-tree, we provide such
options, but when a tree block in extent
tree happens, the backref mismatch error messages won't really help to
guide user to use --init-extent-tree
option.
How do you think about the ask-user method?
Thanks,
Qu
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
