On Wed, Feb 11, 2015 at 08:33:03AM +0800, Qu Wenruo wrote: > >> Also, since only 2 patches is modified(although other part is slightly > >> modified to match the change), to avoid mail bombing, I created the pull > >> request on github and only send the first 2 patches with cover-letter. > >> https://github.com/kdave/btrfs-progs/pull/5 > > Sending the changed patches only is ok (if you point me at the rest of > > the patches), but it's not necessary to open the github pull request. > > > > The version to version changelogs are also stored in the commit > > changelogs, that's a bit unexpected for a branch to be pulled. > Oh, very sorry for this. > I was meant to save your time, but I forgot that pull branch won't emit > the changelog like patches. Pulled except the last patch, and I've cleaned up some bits so please have a look. It's basically what I'd tell you during a normal review but now it was easier to do myself. My concern about the patch "btrfs-progs: Allow open_ctree use backup tree root or search it automatically if primary..." is the 'automatically' part. Falling to the backup roots should be IMO on request. The tools should have (and some of them already do have) commandline options to request a given backup root. That way the user can try the default action and then decide if the backup roots are fine for use. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
