On 02/10/2015 01:28 PM, Eric Sandeen wrote:
On 2/9/15 2:03 PM, Josef Bacik wrote:
The METADUMP super flag makes us skip doing the chunk tree reading which isn't
helpful for the new restore since we have a valid chunk tree. But we still want
to have a way for the kernel to know that this is a metadump restore so it
doesn't do things like verify data checksums. We also want to skip some of the
device extent checks in fsck since those will obviously not match. Thanks,
coverity points out that the "metadump_v2" flag is never set to anything but 0.
# git show 797a937e | grep metadump_v2
Btrfs-progs: Introduce metadump_v2
+ int metadump_v2 = 0;
+ (!metadump_v2 &&
+ if (metadump_v2)
#
is that ... intentional?
Sort of? So I originally skipped these checks with metadump_v2 set, but
then I fixed btrfs-image to fix the chunk tree, so I deleted that stuff.
However btrfs-image doesn't fix everything so we still want to skip
sometimes. Soooooo I'll just delete this bit and add it back when I
decide what I want. Thanks,
Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
