Re: [PATCH v5 2/9] btrfs: Make btrfs_parse_options() parse mount option in a atomic way

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 30, 2015 at 05:20:47PM +0800, Qu Wenruo wrote:
> v5:
>   Add ACCESS_ONE() macro to avoid aggressive compiler optimization to
>   not read fs_info->mount_opt to new_opt but always use fs_info->mount_opt.

This holds only up to this patch, ie. that there are other threads that
could change value of fs_info->mount_opt concurrently. But then the
per-transaction mount options will avoid that as space cache status will
be unmodified by remounts (through parse_options).

So either drop ACCESS_ONCE or please write a comment and explain why
it's still needed.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux