Re: [PATCH] Drop feature defines from C files, in favour of CFLAGS defines.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 18, 2015 at 01:52:58AM +0000, Dimitri John Ledkov wrote:
> glibc 2.10+ (5+ years old) enables all the desired features:
> _XOPEN_SOURCE 700, __XOPEN2K8, POSIX_C_SOURCE, DEFAULT_SOURCE; with a
> single _GNU_SOURCE define in the makefile alone. For portability to
> other libc implementations (e.g. dietlibc) _XOPEN_SOURCE=700 is also
> defined.

Sounds reasonable to me.

> This also resolves Debian bug report filed by Michael Tautschnig -
> "Inconsistent use of _XOPEN_SOURCE results in conflicting
> declarations". Whilst I was not able to reproduce the results, the
> reported fact is that _XOPEN_SOURCE set to 500 in one set of files
> (e.g. cmds-filesystem.c) generates/defines different struct stat from
> other files (cmds-replace.c).
> 
> This patch thus cleans up all feature defines, and sets them at a
> consistent level.

Thanks, applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux