Re: [PATCH 1/2] btrfs-progs: tests, add support for running commands under root

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > Most of the checks run fine without root, but some of them may need to
> > do a mount test or access the data. Add the support to selectively run
> > commands under root, hardcoded to sudo for now.
> I'm a little worried about using sudo in such test.

Opposed to running the whole testsuite as root? Most tests are fine to
be run under the user privileges.

> If the test is ran by a script, test will be stuck waiting for input and 
> timeout after a long time.

Good point, I'll add --non-interactive that will abort in that case.

> I prefer NOT RUN just like xfstests.

But xfstests do not run if there's a missing implementation or
incomplete testing setup, ie. something that cannot be fixed by other
means.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux