Re: btrfs scrub status reports not running when it is

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 15, 2015 at 10:02:37AM -0800, Zach Brown wrote:
> > > It says that scrub isn't running if any devices have completed.  If you drop
> > > all those ret < 0 conditional branches that are either noops or wrong, does it
> > > work like you'd expect?
> > 
> > Why wrong? The ioctl callback returns -ENODEV or -ENOTCONN that get
> > translated to the errno values and ioctl(...) returns -1 in both cases.
> 
> Wrong because returning 0 on the first ENOTCONN, instead of continuing
> to find more devices which might still be scrubbing, leads to this
> confusing status message.

You're right, fix on the way.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux