On 2015-01-05 11:36, Goffredo Baroncelli wrote:
These first 2 points can be easily handled with some simple logic in userspace without needing a mount helper.On 2015-01-05 12:31, Lennart Poettering wrote:On Mon, 05.01.15 10:46, Harald Hoyer (harald@xxxxxxxxxx) wrote:We have BTRFS_IOC_DEVICES_READY to report, if all devices are present, so that a udev rule can report ID_BTRFS_READY and SYSTEMD_READY. I think we need a third state here for a degraded RAID, which can be mounted, but should only after a certain timeout/kernel command line params. We also have to rethink how to handle the udev DB update for the change of the state. incomplete -> degraded -> completeI am not convinced that automatically booting degraded arrays would be a good idea. Instead, requiring one manual step before booting a degraded array sounds OK to me.I think that a good use case is when the root filesystem is a raid one. However I don't think that the current architecture is enough flexible to perform this job: - mounting a raid filesystem in degraded mode is good for some setup but it is not the right solution for all: a configure parameter to allow one behavior or the other is needed: - the degraded mode should be allowed only if not all the devices are discovered AND a timeout is expired. This timeout is another variable which (IMHO) should be configurable;
This can be solved by providing 2 new return values for the BBTRFS_IOC_DEVICES_READY ioctl (instead of just one), one for for arrays that are in such a state that losing another disk will almost certainly cause data loss (ie, a RAID6 with two missing devices, or a BTRFS raid1/10 with one missing device), and one for an array (theoretically) won't lose any data if one more device drops out (ie, a RAID6 (or something with higher parity) with one missing disk), and then provide a module parameter to allow forcing the kernel to report one or the other.- there are different degrees of degraded mode: if the raid is a RAID6, losing a device would be acceptable; loosing two devices may be unacceptable. Again there is no a simple answer; it is needed a configurable policy;
Point 4 would require for some kind of continuous scanning/notification (and therefore add more bulk, the lack of which is in my opinion one of the biggest advantages of BTRFS over ZFS), and even then there will always be the possibility that a device drops out between you calling the ioctl and trying to mount the filesystem.- pay attention that the current architecture has some flaws: if a device disappear during the device discovery, ID_BTRFS_READY returns OK even if a device is missing.
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
