[PATCH] btrfs-progs: Fix btrfs fi show by uuid and label

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Commit 8be2fff (btrfs-progs: apply realpath for btrfs fi
show when mount point is given) changed the behavior of
btrfs fi show to return an error if the call to realpath()
failed.  This broke the ability to specify a filesystem by
uuid or label.

So let's not consider a failed call to realpath() as an
error.  If the user really specified a bad device, just
return nothing like we did before.
---
 cmds-filesystem.c |    9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/cmds-filesystem.c b/cmds-filesystem.c
index 8f037dd..a654e6f 100644
--- a/cmds-filesystem.c
+++ b/cmds-filesystem.c
@@ -901,13 +901,8 @@ static int cmd_show(int argc, char **argv)
 		 *     realpath do  /mnt/btrfs/  => /mnt/btrfs
 		 *     which shall be recognized by btrfs_scan_kernel()
 		 */
-		if (!realpath(search, path)) {
-			fprintf(stderr, "ERROR: Could not show %s: %s\n",
-					search, strerror(errno));
-			return 1;
-		}
-
-		search = path;
+		if (realpath(search, path))
+			search = path;
 
 		/*
 		 * Needs special handling if input arg is block dev And if
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux