On 12/19/14 10:06 AM, David Sterba wrote:
> If the tree's empty, we'll get NULL and dereference it.
Hm, but this is under an explicit check for not empty:
while (!cache_tree_empty(roots_info_cache)) {
sooo? Maybe it's just defensive? Nothing really wrong
with being defensive, I suppose, so:
Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> Resolves-Coverity-CID: 1248828
> Signed-off-by: David Sterba <dsterba@xxxxxxx>
> ---
> cmds-check.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/cmds-check.c b/cmds-check.c
> index 6eea36c2f52c..3e7a4ebdce44 100644
> --- a/cmds-check.c
> +++ b/cmds-check.c
> @@ -8075,6 +8075,8 @@ static void free_roots_info_cache(void)
> struct root_item_info *rii;
>
> entry = first_cache_extent(roots_info_cache);
> + if (!entry)
> + break;
> remove_cache_extent(roots_info_cache, entry);
> rii = container_of(entry, struct root_item_info, cache_extent);
> free(rii);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
