Goffredo Baroncelli posted on Mon, 15 Dec 2014 21:02:59 +0100 as
excerpted:
> + printf(" Total disks size: %10s\n",
> + pretty_size(total_block_count));
I really like this patch series. Makes mkfs.btrfs much nicer to use. =:^)
I'm not a dev and won't attempt a technical review, but three very minor
and quick nits:
* Please s/disk/device/, here and possibly elsewhere. I know I'm not the
only one who is trying to make the switch in my own usage, as it looks a
bit foolish (and/or marks the user as an old fogey who's likely to start
lecturing about how a GiB isn't "small", as I'm known to do at times!
=:^) already, as it's only going to be more so over time.
* patch title typo and omission, patch 7: There's a good chance you
already caught it, but just in case, for the next version, s/-o/-q/, and
please mention it's /documentation/ that's patched here (patch 1 adds the
switches to the code).
* Also in patch 7, first chunk, -q|--quiet is added twice...
--
Duncan - List replies preferred. No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master." Richard Stallman
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
