Re: [PATCH 2/2 v4] btrfs-progs: optimize btrfs_scan_lblkid() for multiple calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 11, 2014 at 12:47:35PM +0100, Karel Zak wrote:
>  What I see critical is missing ./configure, because it's pretty ugly
>  to add hardcoded dependencies (e.g. libudev), there is also no checks
>  for another libs, Makefile does not care about place where libs are
>  installed, header files,  etc. etc.

It does, prefix and libdir are set conditionally, DESTDIR works.

>  Is there any fundamental problem with autoconf? If no, then I'm ready
>  to send patches with some autotools stuff. Comments?

Yeah the build dependencies checks would be nice, there's no problem
with autoconf.

The Makefile has been manualy crafted and supports some macro magic to
build several binaries from one rule, static targets, quiet/verbose
build. I want to preserve all of this so transition to automake may take
time (or may not happen in the end).
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux