Hi I'm gearing up to tackle the "Pass fs_info instead of root " project suggested on the wiki. I've read through the entire codebase and made note of 102 functions which could be refactored. Three of these do not make any use of their root argument at all, is it safe to refactor these as well? Namely: btrfs_block_rsv_check : http://lxr.free-electrons.com/source/fs/btrfs/extent-tree.c#L4743 copy_to_sk : http://lxr.free-electrons.com/source/fs/btrfs/ioctl.c#L1931 wait_for_commit : http://lxr.free-electrons.com/source/fs/btrfs/transaction.c#L597 None of these function's users make indirect calls through function pointers. Is it safe to refactor them? I ask because it seems strange they would have unused arguments and I'm worried there might be a reason I've missed. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
