Re: [PATCH 4/4] btrfs-progs: fix csum root copy-n-paste error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 15, 2014 at 04:14:21PM -0700, Zach Brown wrote:
> btrfs_setup_all_roots() had some copy and pasted code for trying to
> setup a root and then creating a blank node if that failed.  The copy
> for the csum_root created the blank node in the extent_root.

The cleanup is good, though I don't see the bug there. Although the passed root
is extent_root in both cases, it's only used to reach the
fs_info->extent_cache:

 131 struct extent_buffer *btrfs_find_create_tree_block(struct btrfs_root *root,
 132                                                  u64 bytenr, u32 blocksize)
 133 {
 134         return alloc_extent_buffer(&root->fs_info->extent_cache, bytenr,
 135                                    blocksize);
 136 }
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux