[PATCH 3/4] btrfs-progs: fix show super unknown flag output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



coverity pointed out that unknown flag printing in show super had some
dead code.  It turns out that first was reset when the first flag was
tested, not when it was output.  We only want to clear it if the first
matching bit is output.  If there are no matching bits then we'll want
to output the unknown flag first.

Signed-off-by: Zach Brown <zab@xxxxxxxxx>
---
 btrfs-show-super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/btrfs-show-super.c b/btrfs-show-super.c
index 456dbd8..2b48f44 100644
--- a/btrfs-show-super.c
+++ b/btrfs-show-super.c
@@ -324,8 +324,8 @@ static void print_readable_incompat_flag(u64 flag)
 				printf("%s ", entry->output);
 			else
 				printf("|\n\t\t\t  %s ", entry->output);
+			first = 0;
 		}
-		first = 0;
 	}
 	flag &= ~BTRFS_FEATURE_INCOMPAT_SUPP;
 	if (flag) {
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux