On Mon, Oct 06, 2014 at 06:42:51PM +0200, David Sterba wrote: > On Wed, Oct 01, 2014 at 10:11:09AM -0400, Josef Bacik wrote: > > Fsck only cares if the cache is really broken, so don't be noisy if the > > generations don't match or other such errors. Thanks, > > Let's put the messages under a --verbose option if they're just noise. > I'll send a followup patch. The printf's are inside free-spache-cache.c so it would need to keep some global state that is read in cmds-check.c and set from random other files. This could be cleanly done by prefixing the printf messages the same way the kernel printk works and then print only the messages below the user-specified level. Also, using printk in sources that are (not yet but will be) shared with kernel is IMHO a good practice. As this is going to be a broader change, I'd like to think about it more and for now will keep the patch out, I hope we can live with the noisy messages. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
