Re: [PATCH] btrfs-progs: force overwrite should wipe stale SB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 10/01/2014 07:26 PM, David Sterba wrote:
On Fri, Sep 05, 2014 at 11:51:24PM +0800, Anand Jain wrote:
+static void wipe_existing_fs(int fd)
+{
...
+	blkid_probe_enable_partitions(pr, 1);
+
+	while (blkid_do_probe(pr) == 0)
+		blkid_do_wipe(pr, 0);

Reported by a user on IRC, I verified it on one of my old test boxes.
The function is missing in older versions of blkid and causes comilation
errors:

     [CC]     utils.o
utils.c: In function ‘wipe_existing_fs’:
utils.c:705:3: warning: implicit declaration of function ‘blkid_do_wipe

utils.o: In function `wipe_existing_fs':
/labs/dsterba/btrfs-progs/utils.c:705: undefined reference to `blkid_do_wipe'
collect2: ld returned 1 exit status
>
blkid_do_wipe is from Novembe 2011, so nothing really new, but I'd still
like to keep the backward compatibility of btrfs-progs.  The

implementation of blkid_do_wipe uses some internal data so it's not
possible to simply copy the implementation. Maybe wiping the first
megabyte is enough.

 for the sake of backward compatible.. the only choice I see as of now
 yes to write our own wipe. will send one.

Anand


--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux