On Mon, Sep 29, 2014 at 06:07:38PM +0200, David Sterba wrote: > On Sun, Sep 28, 2014 at 01:48:11AM -0700, Omar Sandoval wrote: > > The buffer passed to vfs_write in send and several casts of ioctl fields are > > missing the __user annotation. Also fixes a couple of related trivial style > > issues. > > > > Signed-off-by: Omar Sandoval <osandov@xxxxxxxxxxx> > > Reviewed-by: David Sterba <dsterba@xxxxxxx> Thank you. > > @@ -639,8 +640,7 @@ static int send_header(struct send_ctx *sctx) > > - return write_buf(sctx->send_filp, &hdr, sizeof(hdr), > > - &sctx->send_off); > > + return write_buf(sctx->send_filp, &hdr, sizeof(hdr), &sctx->send_off); > > > ret = write_buf(sctx->send_filp, sctx->send_buf, sctx->send_size, > > - &sctx->send_off); > > + &sctx->send_off); > > Please do not fold unrelated changes. My metric for "related" here was that these were call sites of a function I directly modified. Is the preferred form to just split style fixes that we encounter into a separate patch in the series? -- Omar -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
