On Thu, Aug 21, 2014 at 1:07 PM, Naohiro Aota <naota@xxxxxxxxx> wrote:
> free_some_buffer() should not free dirty extent buffers. They should be
> left for later commit.
>
> Signed-off-by: Naohiro Aota <naota@xxxxxxxxx>
> ---
> extent_io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/extent_io.c b/extent_io.c
> index a127e54..8a668be 100644
> --- a/extent_io.c
> +++ b/extent_io.c
> @@ -552,7 +552,7 @@ static int free_some_buffers(struct extent_io_tree *tree)
>
> list_for_each_safe(node, next, &tree->lru) {
> eb = list_entry(node, struct extent_buffer, lru);
> - if (eb->refs == 1) {
> + if (eb->refs == 1 && !(eb->flags && EXTENT_DIRTY)) {
Hi,
Did you meant bitwise and (&) and not logical and (&&) right?
> free_extent_buffer(eb);
> if (tree->cache_size < cache_hard_max)
> break;
> --
> 2.0.4
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Filipe David Manana,
"Reasonable men adapt themselves to the world.
Unreasonable men adapt the world to themselves.
That's why all progress depends on unreasonable men."
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
