On 8/21/14, 1:42 PM, Eric Sandeen wrote: > On 8/20/14, 10:35 PM, Gui Hecheng wrote: >> A memory problem reported by valgrind as follows: >> === Syscall param pwrite64(buf) points to uninitialised byte(s) >> When running: >> # valgrind --leak-check=yes btrfs restore /dev/sda9 /mnt/backup >> >> Because the output buf size is alloced with malloc, but the length of >> output data is shorter than the sizeof(buf), so valgrind report >> uninitialised byte(s). >> We could use calloc to repalce malloc and clear this WARNING away. > > It clears the valgrind error away, but does it hide a real bug? Maybe the relevant question for Marc is - did you get decompression errors during restore? if so then I guess it all makes sense, and the proposed patch seems sane after all, sorry. -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
