On Mon, Aug 11, 2014 at 03:17:11AM +0300, Timofey Titovets wrote: > According to https://btrfs.wiki.kernel.org/index.php/Project_ideas#btrfs > Quote: > merge functionality of btrfstune, eg. under btrfs dev set-seed /dev/ > (discuss the command name though) I've added this project idea long time ago and I'm afraid it's not valid anymore, at least not in the proposed way. > This patch is just code move > After, user can tune btrfs parameters through: > btrfs dev tune -xr /dev/sda2 The btrfstune utility works on an unmounted filesystem and affects the whole filesystem, so the 'device' subgroup is not right here. Most of the commands from the base utility on a mounted filesystem, so a separate btrfstune makes some distinction. The reason for merging the two was to avoid a 1MB binary for very simple thing, the generic filesystem code can be shared with 'btrfs'. The question is what's the right UI, a new subcommand, or via the generic properties command? The property interface is not yet populated, so it might be hard to imagine where the tuning settings would go. Something like this: $ btrfs prop set feature.skinny-metadata 1 /dev/sdx The extended refs can be turned on even on a mounted filesystem, so this would avoid doing 'echo 1 > /sys/fs/btrfs/UUID/features/extended_iref'. At this moment I'm inclined to use the properties interface, which means that the btrfstune utility will stay a bit longer. I'll update the project idea to reflect this so it's not confusing anymore (sorry). -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
