Thanks for the feedback, appreciated.
On Wed, Jul 30, 2014 at 05:55:19PM +0600, Roman Mamedov wrote:
> > +static const char * const cmd_subvol_sync_usage[] = {
> > + "btrfs subvolume sync <path> [<subvol-id>...]",
> > + "Wait until given subvolume(s) are completely cleaned",
> > + "Wait until given subvolume(s) are completely cleaned after deletion.",
>
> I find "cleaned" to be confusing here. "OK, this subvolume is now clean"? At
> the very least this gives an impression that the desired condition is that
> subvolume *still exists*, but is empty.
>
> How about "Wait until given subvolume(s) are completely removed from the
> filesystem. Does not return until all ongoing deletion requests (if any) on
> given subvolume(s) are complete".
Sounds good, I'll use the text in the next version.
> > + "If no subvolume id is given, wait until there are no more snapshots",
>
> Please don't intermix "subvolume" and "snapshot" like that. Better to use
> "subvolume" in all cases to avoid confusion.
Good point, will fix it and the typos.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
