Re: [PATCH RFC] btrfs: code optimize use btrfs_get_bdev_and_sb() at btrfs_scan_one_device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 07/23/2014 01:42 AM, David Sterba wrote:
On Tue, Jul 08, 2014 at 02:38:37AM +0800, Anand Jain wrote:
(for review comments pls).

btrfs_scan_one_device() needs SB, instead of doing it from scratch could
use btrfs_get_bdev_and_sb()

Please see
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=6f60cbd3ae442cb35861bb522f388db123d42ec1

your patch actually reverts the changes. btrfs_get_bdev_and_sb does not
work and it was a pretty nasty bug, we've spent a long afternoon
catching it.

 Ah! It explains why we had a different btrfs_read_dev_super().

 Thanks.
Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux