Re: [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



David Sterba posted on Fri, 04 Jul 2014 15:52:26 +0200 as excerpted:

> I disagree here, it's much more convenient to run 'fi df' anywhere and
> get the output. The system 'df' command works the same way.

Agreed.

I believe the proposed patch (at least based on its commit comment), 
however, simply warns if the fi df is not done on a mount-point, giving 
the mount-point that it's printing information for.  IMO that /is/ 
helpful, and comparable to standard df, which has a mountpoint column, so 
with the patch the same mount-point information is available from fi df 
as from normal df, just a bit differently.

It wasn't quite clear from the discussion whether that would be the case, 
and I was prepared to protest the patch if it wasn't, but the way things 
turned out (based on the commit comment, I don't claim to read code) 
seems fine to me.

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux