On Thu, 2014-07-03 at 18:58 +0200, David Sterba wrote: > On Thu, Jul 03, 2014 at 10:06:34AM +0800, Gui Hecheng wrote: > > The btrfs-image tool should not be run on a mounted filesystem. > > Should not, but for some values of "sometimes" it makes sense, eg. > capturing image of an otherwise quiescent filesystem, a read-only mount > or after a crash. Ah, read-only mount is really a case. > This utility is used for debugging so I'd prefer to let the user do as > he likes, though printing the warning about the mount status is a good > improvement. I agree, then I'll keep the check_mounted and just give a prompt and let it continue. > > The undergoing fs operations may change what you have imaged a while ago, > > this makes the image meanmingless. > > I'm not familiar with the image format, but maybe we can set a bit in > the header when the filesystem was not captured cleanly. Hmm...This is a point, I think I'll give it a try in another patch. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
