On 07/02/2014 08:24 PM, Qu Wenruo wrote: > > -------- Original Message -------- > Subject: Re: [PATCH v2] btrfs: fix nossd and ssd_spread mount option > regression > From: Eric Sandeen <sandeen@xxxxxxxxxx> > To: Qu Wenruo <quwenruo@xxxxxxxxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx > Date: 2014年07月03日 00:12 >> On 7/1/14, 11:19 PM, Qu Wenruo wrote: >>> From: Eric Sandeen <sandeen@xxxxxxxxxx> >>> >>> The commit >>> >>> 0780253 btrfs: Cleanup the btrfs_parse_options for remount. >>> >>> broke ssd options quite badly; it stopped making ssd_spread >>> imply ssd, and it made "nossd" unsettable. >>> >>> Put things back at least as well as they were before >>> (though ssd mount option handling is still pretty odd: >>> >>> Reported-by: Roman Mamedov <rm@xxxxxxxxxxx> >>> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> >>> Signed-off-by: Qu Wenruo <quwenruo@xxxxxxxxxxxxxx> >>> --- >>> v2(By Qu): >>> Make nossd disable ssd and ssd_spread. >>> Add notes in Documentation/btrfs.txt >> Ok, thanks for fixing up a little bit more. >> >> But option handling is still strange even with your changes: >> >> # mount -o ssd /dev/sdc3 /mnt/test; grep sdc3 /proc/mounts >> /dev/sdc3 /mnt/test btrfs rw,seclabel,relatime,ssd,space_cache 0 0 >> >> # mount -o remount,nossd /dev/sdc3 /mnt/test; grep sdc3 /proc/mounts >> /dev/sdc3 /mnt/test btrfs rw,seclabel,relatime,nossd,space_cache 0 0 >> >> # mount -o remount,ssd_spread /dev/sdc3 /mnt/test; grep sdc3 /proc/mounts >> /dev/sdc3 /mnt/test btrfs >> rw,seclabel,relatime,nossd,ssd_spread,space_cache 0 0 >> >> # mount -o remount,ssd /dev/sdc3 /mnt/test; grep sdc3 /proc/mounts >> /dev/sdc3 /mnt/test btrfs >> rw,seclabel,relatime,nossd,ssd_spread,space_cache 0 0 >> >> I'd rather just commit my first patch to fix the regression ASAP, and >> fix the ssd option mess with a second patch which has received careful >> testing. >> >> -Eric > OK, please merge the v1 patch only. > I'll fix the ssd dependency things later. The v1 patch is already queued ;) -chris -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
