Re: [PATCH v2] Btrfs: clear compress-force when remounting with compress option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



(2014/07/02 1:04), David Sterba wrote:
On Mon, Jun 30, 2014 at 10:51:25AM +0800, Wang Shilong wrote:
Steps to reproduce:
  # mkfs.btrfs -f /dev/sdb
  # mount /dev/sdb /mnt -o compress-force=lzo
  # mount /dev/sdb /mnt -o remount,compress=zlib
  # cat /proc/mounts

Remounting from compress-force to compress could not clear compress-force
option. The problem is there is no way for users to clear compress-force
option separately.

Fix this problem by clearing @FORCE_COMPRESS flag when remounting to
compress=xxx.

Suggested-by: Tsutomu Itoh <t-itoh@xxxxxxxxxxxxxx>
Signed-off-by: Wang Shilong <wangsl.fnst@xxxxxxxxxxxxxx>

I'm sorry for lack of answer in the V1 thread, V2 is the minimal bugfix
and I'm fine with it right away.

Reviewed-by: David Sterba <dsterba@xxxxxxx>

Test result (I used your reproducer):
  3.16-rc3:               FAIL
  3.16-rc3 w/ your patch: PASS

Reviewed-by: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx>
Tested-by: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx>

Thanks,
Satoru

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux