On Wed, Jun 25, 2014 at 06:55:49PM -0500, Eric Sandeen wrote:
> open_ctree() is almost 1000 lines long. I've started trying
> to refactor it, primarily into helper functions, and also
> simplifying (?) things a bit at the beginning by removing the
> ret = func(); if (ret) { err = ret; goto ... } dance where it's not
> needed.
>
> Does this look like a reasonable thing to do? Have I cut
> things into the right chunks? Would you rather see it as
> as series of patches, moving one hunk of code at a time?
Looks good to me, I'd prefer separate patches for each helper, for the
sake of easier review. The separation seems ok.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
