On 06/19/2014 03:25 PM, Marc MERLIN wrote:
On Thu, Jun 19, 2014 at 09:12:13AM -0700, Josef Bacik wrote:
Ok undo what you did and apply this and re-run. It is going spit out a
metric
shittone of data, but all I want is the last chunk of stuff between
running build_backref_tree
<some shit>
block <some more shit> wasn't checked
done building backref tree
I changed it to return an error instead of bugging, so if it still bugs
attach
that as well so I can figure out where down the stack we need to fix.
Thanks,
Patch applied, here is the new crash. The output is short, so here is all of
it:
Ok same drill as before, reset and apply this, hopefully no panic this time
diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
index 65245a0..bca5240 100644
--- a/fs/btrfs/relocation.c
+++ b/fs/btrfs/relocation.c
@@ -440,7 +440,7 @@ static void remove_backref_node(struct backref_cache *cache,
free_backref_edge(cache, edge);
if (RB_EMPTY_NODE(&upper->rb_node)) {
- BUG_ON(!list_empty(&node->upper));
+// BUG_ON(!list_empty(&node->upper));
drop_backref_node(cache, node);
node = upper;
node->lowest = 1;
@@ -702,6 +702,7 @@ struct backref_node *build_backref_tree(struct reloc_control *rc,
int err = 0;
bool need_check = true;
+ printk(KERN_ERR "running build_backref_tree\n");
path1 = btrfs_alloc_path();
path2 = btrfs_alloc_path();
if (!path1 || !path2) {
@@ -722,6 +723,8 @@ struct backref_node *build_backref_tree(struct reloc_control *rc,
node->lowest = 1;
cur = node;
again:
+ printk(KERN_ERR "building backref for bytenr %llu level %d\n",
+ cur->bytenr, cur->level);
end = 0;
ptr = 0;
key.objectid = cur->bytenr;
@@ -757,6 +760,7 @@ again:
*/
if (!exist->checked)
list_add_tail(&edge->list[UPPER], &list);
+ printk(KERN_ERR "exist is %llu, checked %d\n", exist->bytenr, exist->checked);
} else {
exist = NULL;
}
@@ -865,6 +869,7 @@ again:
* cached, add the block to pending list
*/
list_add_tail(&edge->list[UPPER], &list);
+ printk(KERN_ERR "found shared ref %llu, needs checking\n", upper->bytenr);
} else {
upper = rb_entry(rb_node, struct backref_node,
rb_node);
@@ -958,14 +963,30 @@ again:
&root->state))
upper->cowonly = 1;
+ printk(KERN_ERR "eb in path %llu, level %d, "
+ "cowonly %d, owner %llu, gen %llu, last "
+ "snap %llu, reloc %d, root %llu\n",
+ upper->bytenr, upper->level,
+ upper->cowonly, upper->owner,
+ btrfs_header_generation(eb),
+ btrfs_root_last_snapshot(&root->root_item),
+ btrfs_header_flag(eb,
+ BTRFS_HEADER_FLAG_RELOC),
+ root->objectid);
+
/*
* if we know the block isn't shared
* we can void checking its backrefs.
*/
- if (btrfs_block_can_be_shared(root, eb))
+ if (btrfs_block_can_be_shared(root, eb)) {
+ printk(KERN_ERR "is shared, need_check"
+ " %d\n", need_check);
upper->checked = 0;
- else
+ } else {
+ printk(KERN_ERR "isn't shared, "
+ "need_check %d\n", need_check);
upper->checked = 1;
+ }
/*
* add the block to pending list if we
@@ -1019,6 +1040,7 @@ next:
edge = list_entry(list.next, struct backref_edge, list[UPPER]);
list_del_init(&edge->list[UPPER]);
cur = edge->node[UPPER];
+ printk(KERN_ERR "doing the checking for block %llu\n", cur->bytenr);
goto again;
}
@@ -1062,7 +1084,12 @@ next:
continue;
}
- BUG_ON(!upper->checked);
+ if (!upper->checked) {
+ printk(KERN_ERR "block %llu wasn't checked\n",
+ upper->bytenr);
+ err = -EINVAL;
+ goto out;
+ }
BUG_ON(cowonly != upper->cowonly);
if (!cowonly) {
rb_node = tree_insert(&cache->rb_root, upper->bytenr,
@@ -1114,6 +1141,7 @@ next:
}
}
out:
+ printk(KERN_ERR "done building backref tree\n");
btrfs_free_path(path1);
btrfs_free_path(path2);
if (err) {
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
