Re: Transaction commit: none (default)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 16, 2014 at 03:09:53PM +0800, Wang Shilong wrote:
> >>>>1) Is that expected/normal? It looks kind of spamming/useless to me?
> >>>>2) If it's useful, what's the use I'm not getting?
> >>>Addressed a issue that subvolumes reappear after deletetion if poweroff
> >>>happen.
> >>>
> >>>http://www.spinics.net/lists/linux-btrfs/msg29547.html
> >>I see, thank you for the pointer.
> >>In the case of my script, it's console spam that I wish I could make go
> >>away, but grep -v will do that for me :)
> >>
> >>If it annoys other people, maybe having a -q (quiet) that removes this
> >>message would be useful?
> >IMHO it should be the reverse: be quiet by default and require -v, just
> >as more explicit behaviour also requires additional options.
> >With default options I expect default behaviour. Telling me that the
> >default behaviour happened is just noise.
> Fair point, Another question is that current default output has been there.
> Let's Cc David, and see what is his opinion.

I agree the way it's now (2 lines of output per 1 subvolume) is not
good, but I'd like to keep the information about the commit mode, even
for the default one. So would something like this work?

current:
Delete subvolume '/mnt/subvol'

new:
Delete subvolume (no commit): '/mnt/subvol'

or
Delete subvolume (commit): '/mnt/subvol'

Where the modes of commit (none, each) would stick to each line, and the
'commit after last' would say 'commit' for the last one. Ie. no separate
line that mentions the commit mode globally.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux