Re: btrfs balance crash BUG ON fs/btrfs/relocation.c:1062 or RIP build_backref_tree+0x9fc/0xcc4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 17, 2014 at 11:29:57AM -0700, Josef Bacik wrote:
> >I'm sure that filesystem is damaged in some way, but the kernel of course
> >should not crash.
> >
> 
> I don't have this mail client setup right to send patches, can you just 
> go into relocation.c in build_backref_tree and remove the need_check = 
> false; statement and see if that fixes it.  Thanks,

Sure, I'll try that tomorrow when I have access to that machine.

Just to be clear
1) You mean this one, right?
				if (!upper->checked && need_check) {
					need_check = false;   <-- delete this
					list_add_tail(&edge->list[UPPER],
						      &list);
				} else

2) is your guess that the BUG_ON I'm getting shouldn't be triggered
and your proposed patch could fix that, or that I do have an FS problem 
but that we're just going to make the kernel more lenient and not crash on it?

Thanks,
Marc
-- 
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
                                      .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/  
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux