On Fri, May 30, 2014 at 02:10:28PM +0800, Anand Jain wrote: > >>@@ -572,6 +572,26 @@ static void init_feature_attrs(void) > >> } > >> } > >> > >>+int rm_device_membership(struct btrfs_fs_info *fs_info, > >>+ struct btrfs_device *one_device) > > > >The name is too generic for a non-static function, so it would be good > >to add at least the btrfs_ prefix. Same applies to the change of > >'add_device_membership' in the next patch. > > Yes indeed. I wanted it to change as well. But the diff became > unfriendly to read. I shall do that in a separate patch. No problem with doing the rename changes in a separate patch, but here you introduce a new function, that should get the right name from the beginning. If this would look inconsitent with the add_ counterpart, then do the rename of add_ in advance. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
